[mlir][spirv] Update spirv validation for module.mlir #158678
Conversation
This is to check that the new spir-val behaviour works correctly. Subsequent PRs will add validation to other target tests.
|
@llvm/pr-subscribers-mlir-spirv Author: Igor Wodiany (IgWod-IMG) ChangesThis is to check that the new Full diff: https://github.com/llvm/llvm-project/pull/158678.diff 1 Files Affected:
diff --git a/mlir/test/Target/SPIRV/module.mlir b/mlir/test/Target/SPIRV/module.mlir
index d4000dfa53810..7e52e549b5266 100644
--- a/mlir/test/Target/SPIRV/module.mlir
+++ b/mlir/test/Target/SPIRV/module.mlir
@@ -4,7 +4,7 @@
// RUN: %if spirv-tools %{ rm -rf %t %}
// RUN: %if spirv-tools %{ mkdir %t %}
// RUN: %if spirv-tools %{ mlir-translate --no-implicit-module --serialize-spirv --split-input-file --spirv-save-validation-files-with-prefix=%t/module %s %}
-// RUN: %if spirv-tools %{ ls %t/module*.spv | xargs -I{} spirv-val {} %}
+// RUN: %if spirv-tools %{ spirv-val %t %}
// CHECK: spirv.module Logical GLSL450 requires #spirv.vce<v1.0, [Shader], []> {
// CHECK-NEXT: spirv.func @foo() "Inline" {
|
|
@llvm/pr-subscribers-mlir Author: Igor Wodiany (IgWod-IMG) ChangesThis is to check that the new Full diff: https://github.com/llvm/llvm-project/pull/158678.diff 1 Files Affected:
diff --git a/mlir/test/Target/SPIRV/module.mlir b/mlir/test/Target/SPIRV/module.mlir
index d4000dfa53810..7e52e549b5266 100644
--- a/mlir/test/Target/SPIRV/module.mlir
+++ b/mlir/test/Target/SPIRV/module.mlir
@@ -4,7 +4,7 @@
// RUN: %if spirv-tools %{ rm -rf %t %}
// RUN: %if spirv-tools %{ mkdir %t %}
// RUN: %if spirv-tools %{ mlir-translate --no-implicit-module --serialize-spirv --split-input-file --spirv-save-validation-files-with-prefix=%t/module %s %}
-// RUN: %if spirv-tools %{ ls %t/module*.spv | xargs -I{} spirv-val {} %}
+// RUN: %if spirv-tools %{ spirv-val %t %}
// CHECK: spirv.module Logical GLSL450 requires #spirv.vce<v1.0, [Shader], []> {
// CHECK-NEXT: spirv.func @foo() "Inline" {
|
3 participants
This is to check that the new
spirv-valbehaviour works correctly. Subsequent PRs will add validation to other target tests. This requires the most recent SPIRV-Tools to work; for existing build directories using bundled SPIR-V tools, runningSPIRVTools-updatecmake target should update them accordingly.The minimum required SPIRV-Tools version is commit
14d42009a9435c34ea55b26cc8d92240c428a052, merged in KhronosGroup/SPIRV-Tools#6292